(POOLER-47) Send clone errors up #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates vmpooler to ensure clone errors, and other pool manager errors are raised to the parent method. Without this change vmpooler gets stuck after a connection fails during clone operations and will not attempt to clone again.
mattkirby
force-pushed
the
send_clone_errors_up
branch
from
a8ac3f5 to
f859826
Compare
rick
approved these changes
Dec 1, 2016
| @@ -621,11 +627,12 @@ def _check_pool(pool, vsphere) | |||
| if inventory[vm] | |||
| begin | |||
| destroy_vm(vm, pool['name'], vsphere) | |||
| rescue | |||
| rescue => err | |||
| $logger.log('s', "[!] [#{pool['name']}] '#{vm}' destroy appears to have failed") | |||
There was a problem hiding this comment.
Might be able to consolidate this log line with the new one below.
|
I'm pretty much +1 on this, for whatever that's worth given my general lack of familiarity with vmpooler code base. If the code were a little easier to work with in the first place and if there wasn't a somewhat urgent need to deploy this I might suggest writing tests to validate the logging and follow-up attempts to clone again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates vmpooler to ensure clone errors, and other pool manager errors are raised to the parent method. Without this change vmpooler gets stuck after a connection fails during clone operations and will not attempt to clone again.