Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guestinfo.hostname to VirtualMachineConfigSpecs #139

Merged
merged 1 commit into from
Nov 13, 2015

Conversation

heathseals
Copy link
Contributor

This commit adds a custom guestinfo keyword and hostname variable
that allows the VMware Tools to query the hostname.

root@akyjym751lr8cu3:~# vmtoolsd --cmd "info-get guestinfo.hostname"
akyjym751lr8cu3

This should allow us some flexibility in moving away from the requirement to talk to vCenter during bootstrap of a pooler VM in order to obtain the hostname.

This commit adds a custom guestinfo keyword and hostname variable
that allows the VMware Tools to query the hostname.
@underscorgan
Copy link
Contributor

👍

@heathseals
Copy link
Contributor Author

@sschneid can you take a look when you have a moment?

@sschneid
Copy link
Contributor

I'm going to add a few of our more esoteric OS pools to vmpooler-dev to make sure this doesn't break anything. Pending manual testing, a huge 👍 from me!

@sschneid
Copy link
Contributor

Looks good in dev, 🚢!

@sschneid sschneid removed their assignment Nov 13, 2015
sschneid added a commit that referenced this pull request Nov 13, 2015
add guestinfo.hostname to VirtualMachineConfigSpecs
@sschneid sschneid merged commit 1a6cd99 into puppetlabs:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants