Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(QENG-2952) Check that SSH is available #130

Merged
merged 2 commits into from
Sep 17, 2015

Conversation

sschneid
Copy link
Contributor

SSH should be available before a VM is moved from the 'pending' queue to
'ready'.

check_ssh should probably be a function in the tradition of DRY; I'm
going to hopefully follow up this PR with a Vmpooler::Utility library.

SSH should be available before a VM is moved from the 'pending' queue to
'ready'.

`check_ssh` should probably be a function in the tradition of DRY; I'm
going to hopefully follow up this PR with a `Vmpooler::Utility` library.
@sschneid
Copy link
Contributor Author

Blah, fixing spec tests...

@sschneid
Copy link
Contributor Author

Tests are passing now, review away!

@colinPL
Copy link
Contributor

colinPL commented Sep 17, 2015

Can you put this up in dev?

@sschneid
Copy link
Contributor Author

Can you put this up in dev?

Already is. :)

colinPL added a commit that referenced this pull request Sep 17, 2015
@colinPL colinPL merged commit 6395d02 into puppetlabs:master Sep 17, 2015
@sschneid sschneid deleted the check_ssh_before_marking_ready branch September 17, 2015 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants