Skip to content

(Bug): do not pass dsc_timeout as timeout parameter to DSC resource params #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

(Bug): do not pass dsc_timeout as timeout parameter to DSC resource params #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b75d861
do not pass dsc_timeout as timeout parameter to DSC resource params
schlitzered Nov 21, 2024
87fc0e2
(maint) - Fix Layout/EmptyLineAfterGuardClause & Metrics/MethodLength
Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ def format_ciminstance(variable_name, class_name, property_hash)
#
# @param resource [Hash] a hash with the information needed to run `Invoke-DscResource`
# @return [String] A string representing the PowerShell definition of the InvokeParams hash
def invoke_params(resource)
def invoke_params(resource) # rubocop:disable Metrics/MethodLength
params = {
Name: resource[:dscmeta_resource_friendly_name],
Method: resource[:dsc_invoke_method],
Expand All @@ -917,6 +917,10 @@ def invoke_params(resource)
params[:ModuleName] = resource[:dscmeta_module_name]
end
resource[:parameters].each do |property_name, property_hash|
# ignore dsc_timeout, since it is only used to specify the powershell command timeout
# and timeout itself is not a parameter to the DSC resource
next if property_name == :dsc_timeout

# strip dsc_ from the beginning of the property name declaration
name = property_name.to_s.gsub(/^dsc_/, '').to_sym
params[:Property][name] = case property_hash[:mof_type]
Expand Down