do not pass dsc_timeout as timeout parameter to DSC resource params #359
Conversation
|
|
|
Hi @schlitzered, it looks like there is a few rubocop errors in this PR, could you address them? |
remove one comment line to make test happy
well the only check that complained was 43 instead of 42 lines in one function. i just removed one of the two comments i have added, and now the functions is back to 42 lines, and the check should be passing. |
|
okay, it is still failing. no clue why, the actual logic is only one line, if have no clue how i should make this any shorter. |
|
@schlitzered in niche cases like this it's absolutely fine to just add an exclusion, you can disable inline with |
|
@schlitzered thanks for picking up on this and submitting the PR to get the ball rolling, I've raised #366 rather than to go back and forth with you for rubocop fixes 🙂 |
Summary
dsc_timeout is used to set the timeout on how long puppet/powershell will wait on the execution of a command.
dsc_timeout is also passed as "timeout" to the DSC resource parameters itself.
but it seems like DSC resources do not have a timout parameter.
see also: #358
Related Issues (if any)
#358
Checklist
sry, i am not a ruby guy, and i have no clue on how to write Spec/Acceptance tests.