Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RK-368) remove "purge_whitelist" setting #1277

Merged

Conversation

tvpartytonight
Copy link
Contributor

da2c636 deprecated the "purge_whitelist"
setting in favor of "purge_allowlist". This change removes "purge_whitelist"
entirely.

Please add all notable changes to the "Unreleased" section of the CHANGELOG in the format:

- (JIRA ticket) Summary of changes. [Issue or PR #](link to issue or PR)

@tvpartytonight tvpartytonight requested a review from a team February 14, 2022 22:44
@tvpartytonight
Copy link
Contributor Author

tvpartytonight commented Feb 14, 2022

I don't really consider this to be a part of RK-368, but just taking advantage of the 4.x release and making deprecations a reality.

Copy link
Contributor

@mwaggett mwaggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry, but otherwise looks good to me!

@Magisus
Copy link
Collaborator

Magisus commented Feb 15, 2022

I think you should tag that ticket in this. I think it's definitely part (but not all) of it.

da2c636 deprecated the "purge_whitelist"
setting in favor of "purge_allowlist". This change removes "purge_whitelist"
entirely.
@tvpartytonight tvpartytonight force-pushed the maint-purge-whitelist-removal branch from 7538ebc to c7b3b62 Compare February 15, 2022 17:05
@tvpartytonight tvpartytonight changed the title (maint) remove "purge_whitelist" setting (RK-368) remove "purge_whitelist" setting Feb 15, 2022
@mwaggett mwaggett merged commit 0992a9d into puppetlabs:4.x Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants