(CODEMGMT-1454) Ensure missing repo caches are re-synced #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `status` method for stateful git repos to check for the presence of the git cache when determining whether repo updates are necessary. Previously, if the repo's working dir and git dir were present, but the cache was missing, the `@repo.dirty?` check would fail when attempting to diff the workdir (`object not found - no match for id`). This would occur during an environment deploy if the environment used the same remote repo as another environment that had been deleted (and thus its artifacts cleaned up). By setting the status to `:mismatched` when the cache doesn't exist, we ensure that the cache is resynced and the deployment may proceed.
Magisus
approved these changes
Aug 19, 2021
|
We're going to add a test for the scenario that revealed this bug at a different level (in PE). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
statusmethod for stateful git repos to check for thepresence of the git cache when determining whether repo updates are necessary.
Previously, if the repo's working dir and git dir were present, but the cache
was missing, the
@repo.dirty?check would fail when attempting to diff theworkdir (
object not found - no match for id). This would occur during anenvironment deploy if the environment used the same remote repo as another
environment that had been deleted (and thus its artifacts cleaned up). By
setting the status to
:mismatchedwhen the cache doesn't exist, we ensure thatthe cache is resynced and the deployment may proceed.