Fix check:git_ignore rake task for git >= 2.32.0 #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me this also always fails with |
ekohl
force-pushed
the
fail-if-git-ls-files-failed
branch
from
b7f7cc5 to
61ce17b
Compare
ekohl
changed the title
|
I included #351 now. |
ekohl
force-pushed
the
fail-if-git-ls-files-failed
branch
from
61ce17b to
9539a84
Compare
|
Looking like this will go in rather than #351. Again, will need rebasing as the changes come in. |
|
On a second look, this can actually go in now if you are happy @ekohl ? |
Since git 2.32.0, the task check:git_ignore failed with an error message: "fatal: ls-files -i must be used with either -o or -c". Fixed by adding `--cached` option to `git ls-files`.
ekohl
force-pushed
the
fail-if-git-ls-files-failed
branch
from
9539a84 to
30595b7
Compare
|
I did a trivial rebase and would be happy if this was merged & released. |
chelnak
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHen running tests I noticed this:
However, rake proceeded so it wasn't failing.
This isn't a complete PR, but I wanted to at least make this obvious and so I wouldn't forget.