Restructure PuppetLint rake tasks so they can be configurable #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaludy
force-pushed
the
feature/puppet-lint-config
branch
from
59c9482 to
a4bed8a
Compare
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 43.28% 43.61% +0.33%
==========================================
Files 11 11
Lines 841 846 +5
==========================================
+ Hits 364 369 +5
Misses 477 477
Continue to review full report at Codecov.
|
ekohl
reviewed
Nov 17, 2021
| # spec_helper.rb in an individual module | ||
| PuppetLint.configuration.relative = true | ||
| PuppetLint::RakeTask.new(:lint) do |config| | ||
| config.fail_on_warnings = true |
There was a problem hiding this comment.
This setting was lost in the refactor. I opened #347 to fix the regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the spec helper configures
PuppetLintin such a way that it's not easy to add extra directories or disable checks for a local module. Basically, you have to completely redefine the Rake task exactly howpuppetlabs_spec_helperdoes it today, which is not idea.Instead, this changes over to using the
PuppetLint.configurationclass to set the global options, this way things likeignore_pathscan be appended to easily in aspec_helper_local.rblike so: