Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10617) Add property module_hotfixes #28

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

seriv
Copy link
Contributor

@seriv seriv commented Mar 26, 2020

(MODULES-10617) Add property module_hotfixes..
Per https://dnf.readthedocs.io/en/latest/modularity.html#hotfix-repositories,
if package you have rebuilt and put into your local repository belongs to
a module, it will not be installed even with better version, because
of the filtering by modules.

To make the system use packages from a repository regardless of their
modularity, specify module_hotfixes=true in the .repo file.
This protects the repository from package filtering.

@seriv seriv requested a review from a team March 26, 2020 16:21
@GabrielNagy
Copy link
Contributor

Hi @seriv, thanks for your contribution!

I created MODULES-10617 to track this ticket. Can you update your commit to also contain the ticket reference? Such as: (MODULES-10617) Add property module_hotfixes. Otherwise this should be good to merge.

Thanks!

@seriv seriv force-pushed the module_hotfixes branch from e65d81d to 387d26a Compare April 5, 2020 17:11
@seriv
Copy link
Contributor Author

seriv commented Apr 7, 2020

Hi @GabrielNagy,
I've modified commit as you suggested.

Regards,
Sergey.

Hi @seriv, thanks for your contribution!

I created MODULES-10617 to track this ticket. Can you update your commit to also contain the ticket reference? Such as: (MODULES-10617) Add property module_hotfixes. Otherwise this should be good to merge.

Thanks!

@GabrielNagy
Copy link
Contributor

@seriv sorry, should have been more specific. Please add the ticket ID in the commit title (first line), not the body. That way our JIRA will automatically link the PR to the ticket. Thanks!

Per https://dnf.readthedocs.io/en/latest/modularity.html#hotfix-repositories,
if package you have rebuilt and put into your local repository belongs to
a module, it will not be installed even with better version, because
of the filtering by modules.

To make the system use packages from a repository regardless of their
modularity, specify module_hotfixes=true in the .repo file.
This protects the repository from package filtering.
@seriv seriv force-pushed the module_hotfixes branch from 387d26a to a14c059 Compare April 12, 2020 00:37
@GabrielNagy GabrielNagy changed the title Add property module_hotfixes (MODULES-10617) Add property module_hotfixes Apr 13, 2020
@GabrielNagy GabrielNagy merged commit fcaa6ec into puppetlabs:master Apr 13, 2020
@seriv seriv deleted the module_hotfixes branch April 13, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants