(MODULES-10246) Proxy settings allow empty string #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorin-Pleava
force-pushed
the
MODULES-10246/yum_repo_core_proxy_accepts_empty_string
branch
from
13d8c88 to
05e93e3
Compare
Dorin-Pleava
requested review from
luchihoratiu,
GabrielNagy,
gimmyxd and
a team
and removed request for
a team
luchihoratiu
approved these changes
Dec 13, 2019
Dorin-Pleava
force-pushed
the
MODULES-10246/yum_repo_core_proxy_accepts_empty_string
branch
from
05e93e3 to
ffd1db6
Compare
luchihoratiu
approved these changes
Dec 13, 2019
Dorin-Pleava
force-pushed
the
MODULES-10246/yum_repo_core_proxy_accepts_empty_string
branch
from
ffd1db6 to
c0499f3
Compare
GabrielNagy
reviewed
Dec 17, 2019
GabrielNagy
reviewed
Dec 17, 2019
This PR enables the Yum Repo Core to accept an empty string as proxy setting, to bypass any global proxy settings when accessing the repository. In case of EL 8, '_none_' will be replaced with '' (empty string).
mihaibuzgau
force-pushed
the
MODULES-10246/yum_repo_core_proxy_accepts_empty_string
branch
from
c0499f3 to
594bb32
Compare
luchihoratiu
approved these changes
Dec 18, 2019
|
I think this change has broken the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Yum Repo Core to accept an empty string as proxy
setting, to bypass any global proxy settings when accessing the
repository.