pdksync - (FM-7392) - Puppet 6 Testing Changes #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmcmaw Failing test's |
|
Unit Test's now pass. Acceptance test's still failing |
pmcmaw
force-pushed
the
pdksync_FM-7392_pdk_update
branch
2 times, most recently
from
582247a
to
f1089e0
Compare
pmcmaw
force-pushed
the
pdksync_FM-7392_pdk_update
branch
from
f1089e0
to
21c82bc
Compare
|
Great work @pmcmaw @david22swan 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(FM-7392) - Puppet 6 Testing Changes
pdk version:
1.7.0For the spec_helper_acceptance change I have added in some logic to only install augeas_core if the puppet version is 6.0.0, if the version is greater it will hard fail. This will remind the modules team when the newer version of puppet is released, that we should remove this work around.
I have tested this logic on the following versions:
5.0.0 (installs nothing)
6.0.0 (installs augeas_core)
6.0.1 (Hard failure stating that the installation should be removed)