Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PE-31763) Remove the dependency on stdlib #90

Merged
merged 2 commits into from
Apr 19, 2021
Merged

(PE-31763) Remove the dependency on stdlib #90

merged 2 commits into from
Apr 19, 2021

Conversation

jarretlavallee
Copy link
Contributor

Prior to this commit, this module required puppetlabs-stdlib to be
functional. This commit removes puppetlabs-stdlib as a depencency.

(PE-31763) Remove the dependency on stdlib
de83191 
Prior to this commit, this module required puppetlabs-stdlib to be
functional. This commit removes puppetlabs-stdlib as a depencency.
@jarretlavallee jarretlavallee requested a review from a team as a code owner April 13, 2021 16:18
@puppet-community-rangefinder
Copy link

puppet_metrics_collector::pe_metric is a type

that may have no external impact to Forge modules.

puppet_metrics_collector::system is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

(main) Remove the sort function
2ead2fd 
Prior to this commit, the sort function was used to sort the hosts
returned from the PuppetDB queries. This commit moves the logic to the
PuppetDB query to do the sorting and removes the sort function. This
fixes compatibility with 5.x that did not have the sort function.
Sharpie
Sharpie approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jarretlavallee jarretlavallee merged commit df0ddde into puppetlabs:master Apr 19, 2021
@jarretlavallee jarretlavallee deleted the fix/master/remove_stdlib branch April 19, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharpie Sharpie Sharpie approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarretlavallee @Sharpie @MartyEwings