(SUP-2054) Add VMware metrics collection #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Ruby script, `files/vmware_metrics`, that uses `vmware-toolbox-cmd stat` to collect VM performance metrics from an ESXi hypervisor.
This commit updates the `puppet_metrics_collector::sar_metric` type to refer to `puppet_metrics_collector::sytem::scripts_dir` when configuring metrics cleanup jobs. This change allows the `puppet_metrics_collector::system` class to be used without including the `puppet_metrics_collector` class --- which enables spec testing of the system class.
This commit updates the `puppet_metrics_collector::system` class to include collection of VMware metrics if the virtualization platform is detected to be VMware.
puppet_metrics_collector::sar_metric is a typethat may have no external impact to Forge modules. puppet_metrics_collector::system is a classthat may have no external impact to Forge modules. puppet_metrics_collector::system::vmware is a classthat may have no external impact to Forge modules. This module is declared in 0 of 575 indexed public
|
|
Example output: # cat /opt/puppetlabs/puppet-metrics-collector/vmware/busier-becoming/20200918T194503Z.json |python -m json.tool
{
"servers": {
"busier-becoming": {
"vmware": {
"host": {
"host.cpu.coresPerPkg": {
"type": "static",
"units": "count",
"value": 20
},
"host.cpu.processorMHz": {
"type": "instant",
"units": "MHz",
"value": 1995
}
},
"resources": {
"guest.mem.ballooned": {
"type": "instant",
"units": "KB",
"value": 0
},
"guest.mem.consumed": {
"type": "instant",
"units": "KB",
"value": 8155716
},
"guest.mem.limit": {
"type": "static",
"units": "KB",
"value": -1
},
"guest.mem.mapped": {
"type": "instant",
"units": "KB",
"value": 8255488
},
"guest.mem.reserved": {
"type": "static",
"units": "KB",
"value": 0
},
"guest.mem.swapIn": {
"type": "accumulate",
"units": "KB",
"value": 0
},
"guest.mem.swapOut": {
"type": "accumulate",
"units": "KB",
"value": 0
},
"guest.mem.swapped": {
"type": "instant",
"units": "KB",
"value": 0
},
"ovhd.mem.swapIn": {
"type": "accumulate",
"units": "KB",
"value": 0
},
"ovhd.mem.swapOut": {
"type": "accumulate",
"units": "KB",
"value": 0
},
"ovhd.mem.swapped": {
"type": "instant",
"units": "KB",
"value": 0
},
"vm.cpu.contention.cpu": {
"type": "accumulate",
"units": "us",
"value": 53064863
},
"vm.cpu.contention.mem": {
"type": "accumulate",
"units": "us",
"value": 0
},
"vm.cpu.limit": {
"type": "static",
"units": "MHz",
"value": -1
},
"vm.cpu.reserved": {
"type": "static",
"units": "MHz",
"value": 0
},
"vm.cpu.used": {
"type": "accumulate",
"units": "us",
"value": 8929863954
},
"vm.numa.local": {
"type": "instant",
"units": "KB",
"value": 8255488
},
"vm.numa.remote": {
"type": "instant",
"units": "KB",
"value": 0
}
},
"session": {
"provider": "",
"session": {
"type": "static",
"units": "int",
"value": 7350989680269531893
},
"uptime": {
"type": "static",
"units": "us",
"value": 91006153434
},
"uuid.bios": "42 1a 53 a5 db e4 61 a5-0a c9 97 c3 4c 31 c3 f1",
"version": "VMware ESX 6.7.0 build-16713306"
},
"vnet": {
"00:50:56:9a:74:69": {
"limit": {
"type": "static",
"units": "MBps",
"value": -1
},
"num.rx": {
"type": "accumulate",
"units": "packets",
"value": 945092
},
"num.tx": {
"type": "accumulate",
"units": "packets",
"value": 70857
},
"reservation": {
"type": "static",
"units": "MBps",
"value": 0
},
"size.rx": {
"type": "accumulate",
"units": "bytes",
"value": 904013131
},
"size.tx": {
"type": "accumulate",
"units": "bytes",
"value": 7399832
}
}
},
"vscsi": {
"scsi0:0": {
"latency.reads": {
"type": "accumulate",
"units": "us",
"value": 7645046
},
"latency.writes": {
"type": "accumulate",
"units": "us",
"value": 228170729
},
"num.reads": {
"type": "accumulate",
"units": "int",
"value": 7634
},
"num.writes": {
"type": "accumulate",
"units": "int",
"value": 166168
},
"size.reads": {
"type": "accumulate",
"units": "bytes",
"value": 268690944
},
"size.writes": {
"type": "accumulate",
"units": "bytes",
"value": 5444434432
}
}
}
}
}
},
"timestamp": "2020-09-18T19:45:03Z"
} |
The `Style/BracesAroundHashParameters` check gives bad advice that will result in deprecation warnings with Ruby 2.7. This check has been removed upstream starting with RuboCop 0.80.0.
jarretlavallee
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the
puppet_metrics_collector::systemclass to include collection of VMware metrics iffacter virtualreports"vmware". Collection is done viavmware-toolbox-cmd statand includes: