Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting orchestrator paramaters to use correct values, not puppetserver's #65

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Getting orchestrator paramaters to use correct values, not puppetserver's #65

merged 1 commit into from
Aug 3, 2020

Conversation

MirandaStreeter
Copy link
Contributor

@MirandaStreeter MirandaStreeter commented Aug 3, 2020 •
edited
Loading

puppet_metrics_collector::service::orchestrator class was using puppetserver values for its parameters. This corrects that.

@puppet-community-rangefinder
Copy link

puppet_metrics_collector::service::orchestrator is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@MirandaStreeter MirandaStreeter linked an issue Aug 3, 2020 that may be closed by this pull request
puppet_metrics_collector::service::orchestrator doesn't collect orchestrator metrics #64
Closed
@MirandaStreeter
Copy link
Contributor Author

I've tested this out, both ensuring it's enabled and disabled on separate nodes simultaneously. Would still like someone to make sure there isn't anything I've overlooked.

jarretlavallee
jarretlavallee approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MirandaStreeter MirandaStreeter changed the title Getting orchestrator paramaters to use correct values, not puppetdb Getting orchestrator paramaters to use correct values, not puppetserver Aug 3, 2020
@MirandaStreeter MirandaStreeter changed the title Getting orchestrator paramaters to use correct values, not puppetserver Getting orchestrator paramaters to use correct values, not puppetserver's Aug 3, 2020
@MirandaStreeter
Copy link
Contributor Author

Speaking of correcting typos...

@MirandaStreeter MirandaStreeter merged commit f66119e into puppetlabs:master Aug 3, 2020
@MirandaStreeter MirandaStreeter deleted the orchestrator-ensure-fix branch August 3, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarretlavallee jarretlavallee jarretlavallee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

puppet_metrics_collector::service::orchestrator doesn't collect orchestrator metrics
3 participants
@MirandaStreeter @jarretlavallee @MartyEwings