Update the system metrics timestamp key #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the metrics timestamp key name in the output file was `time_stamp_obj`, which caused failures when processing with `json2timeseries.rb` this commit updates the key to be `timestamp` to ensure compatibility with the processing scripts.
Prior to this commit, the system metrics values were strings. This commit changes them to be floats. This adds compatibility with the existing json2timeseries parsing script as it looks for numeric values.
RandellP
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the metrics timestamp key name in the output file
was
time_stamp_obj, which caused failures when processing withjson2timeseries.rbthis commit updates the key to betimestamptoensure compatibility with the processing scripts.
Processing script:
https://github.com/puppetlabs/puppetlabs-puppet_metrics_collector/blob/master/files/json2timeseriesdb#L74
Tk metrics:
https://github.com/puppetlabs/puppetlabs-puppet_metrics_collector/blob/master/files/tk_metrics#L152
Along with the timestamp change, this commit changes the output to be floats instead of integers. This allows it to be parsed by the json script as it expects the values to be numeric.