Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-3881) Add collection for PE console services #174

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Jan 18, 2023

Prior to this change, the metrics collector did not collect metrics from the PE console. This change adds metrics collection for the PE console services.

Prior to this change, the metrics collector did not collect metrics from
the PE console. This change adds metrics collection for the PE console
services.
@m0dular m0dular requested a review from a team as a code owner January 18, 2023 17:49
@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ m0dular
❌ Jarret Lavallee


Jarret Lavallee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puppet-community-rangefinder
Copy link

puppet_metrics_collector is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::service::console is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jarretlavallee
Copy link
Contributor

👍

@MartyEwings
Copy link
Contributor

A wild @jarretlavallee appeared

@MartyEwings MartyEwings added the enhancement New feature or request label Jan 19, 2023
@MartyEwings MartyEwings merged commit 131ae12 into puppetlabs:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants