Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-108) Disable sysstat management by default #116

Merged
merged 1 commit into from
Jun 29, 2021
Merged

(GH-108) Disable sysstat management by default #116

merged 1 commit into from
Jun 29, 2021

Conversation

jarretlavallee
Copy link
Contributor

@jarretlavallee jarretlavallee commented Jun 23, 2021 •
edited
Loading

Prior to this PR, the default was to manage the sysstat package by
default. This PR changes the default to not manage the sysstat
package. It includes logic to only include the system metrics collection
classes when the sysstat package is installed and adds a notify when the
packge is not installed.

Resolves #108

@jarretlavallee jarretlavallee requested a review from a team as a code owner June 23, 2021 13:48
@puppet-community-rangefinder
Copy link

puppet_metrics_collector::system is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jarretlavallee jarretlavallee changed the title (GH-108) Stop managing sysstat by default (GH-108) Add conditional for managing sysstat by default Jun 23, 2021
@jarretlavallee jarretlavallee changed the title (GH-108) Add conditional for managing sysstat by default (GH-108) Add conditional for managing sysstat Jun 23, 2021
@jarretlavallee jarretlavallee changed the title (GH-108) Add conditional for managing sysstat (GH-108) Disable sysstat management by default Jun 28, 2021
@jarretlavallee jarretlavallee force-pushed the gh-108_sysstat branch 2 times, most recently from 16a8c21 to 3d56211 Compare June 28, 2021 16:19
@jarretlavallee
Copy link
Contributor Author

@MartyEwings @m0dular This is finally passing. Do you mind doing a review on it?

m0dular
m0dular reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just needs another rebase on main and I have the one extremely pedantic question about the file resource.

manifests/system.pp Show resolved Hide resolved
(puppetlabsGH-108) Only manage system collection when sysstat is inst…
d41fcd7 
…alled

Prior to this commit, the default was to manage the sysstat package by
default. This commit changes the default to not manage the sysstat
package. It includes logic to only include the system metrics collection
classes when the sysstat package is installed and adds a notify when the
packge is not installed.
@jarretlavallee jarretlavallee merged commit 2477df7 into puppetlabs:main Jun 29, 2021
@jarretlavallee jarretlavallee deleted the gh-108_sysstat branch June 29, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0dular m0dular m0dular approved these changes

Assignees
No one assigned
Labels
backwards-incompatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditionally manage the sysstat package
2 participants
@jarretlavallee @m0dular