Rework namevar of defined types

[m0dular]

Prior to this commit, we instantiated the pe_metric defined types with
"puppet_" in their title. This created issues in the scripts related to
validating the names of the services and output directories. This
commit changes the defined type to include the "puppet_" prefix.

[puppet-community-rangefinder]

puppet_metrics_collector::collect is a type

that may have no external impact to Forge modules.

puppet_metrics_collector::service::ace is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::service::bolt is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::service::orchestrator is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::service::puppetdb is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::service::puppetserver is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::system::cpu is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::system::memory is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::system::postgres is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::system::processes is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::system::vmware is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[jarretlavallee]

LGTM