WARNING: STDIN provided but not specified via '-'

[jarretlavallee]

Describe the Bug

When shipping metrics, the following warning is displayed in the output.

WARNING: STDIN provided but not specified via '-'

This can result in an email every 5 minutes for each service. This warning should be suppressed or fixed

Expected Behavior

The warning should not come up.

Steps to Reproduce

Include the main class and add the following to hiera. These parameters can also be in the class declaration.

puppet_metrics_collector::metrics_server_type: influxdb
puppet_metrics_collector::metrics_server_hostname: influxdb.example.lab
puppet_metrics_collector::metrics_server_port: 80
puppet_metrics_collector::metrics_server_db_name: puppet_metrics

Run the cronjob

[root@puppet ~]# /opt/puppetlabs/puppet-metrics-collector/scripts/tk_metrics --metrics_type puppetserver --output_dir /opt/puppetlabs/puppet-metrics-collector/puppetserver | /opt/puppetlabs/puppet-metrics-collector/scripts/json2timeseriesdb --netcat influxdb.example.lab --convert-to influxdb --port 80 --influx-db puppet_metrics > /dev/null
WARNING: STDIN provided but not specified via '-'

Proposed solution.

Based on https://github.com/puppetlabs/puppetlabs-puppet_metrics_collector/blob/master/files/json2timeseriesdb#L367-L370 we can append - to the end of the command.

/opt/puppetlabs/puppet-metrics-collector/scripts/tk_metrics --metrics_type puppetserver --output_dir /opt/puppetlabs/puppet-metrics-collector/puppetserver | /opt/puppetlabs/puppet-metrics-collector/scripts/json2timeseriesdb --netcat influxdb.example.lab --convert-to influxdb --port 80 --influx-db puppet_metrics - > /dev/null

Testing this is successful.

[root@puppet ~]# /opt/puppetlabs/puppet-metrics-collector/scripts/tk_metrics --metrics_type puppetserver --output_dir /opt/puppetlabs/puppet-metrics-collector/puppetserver | /opt/puppetlabs/puppet-metrics-collector/scripts/json2timeseriesdb --netcat influxdb.home.lab --convert-to influxdb --port 80 --influx-db puppet_metrics - > /dev/null
[root@puppet ~]# /opt/puppetlabs/puppet-metrics-collector/scripts/tk_metrics --metrics_type puppetserver --output_dir /opt/puppetlabs/puppet-metrics-collector/puppetserver | /opt/puppetlabs/puppet-metrics-collector/scripts/json2timeseriesdb --netcat influxdb.example.lab --convert-to influxdb --port 80 --influx-db puppet_metrics -
POST: http://influxdb.example.lab/write?db=puppet_metrics&precision=s 204