Fix command shell escaping

[DavidS]

This changes a couple of places where the postgresql module was passing unsafe values through a shell to avoid the shell altogether.

Big thanks to @smortex for reporting the issue.

[codecov-io]

Codecov Report

Merging #1240 (c73a37b) into main (08e3a51) will increase coverage by 0.27%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
+ Coverage   65.81%   66.09%   +0.27%     
==========================================
  Files          14       14              
  Lines         351      348       -3     
==========================================
- Hits          231      230       -1     
+ Misses        120      118       -2     

Impacted Files	Coverage Δ
...ns/postgresql/postgresql_acls_to_resources_hash.rb	0.00% <0.00%> (ø)
...b/puppet/functions/postgresql/postgresql_escape.rb	0.00% <0.00%> (ø)
...puppet/functions/postgresql/postgresql_password.rb	0.00% <ø> (ø)
lib/puppet/functions/postgresql_escape.rb	0.00% <ø> (ø)
lib/puppet/functions/postgresql_password.rb	0.00% <ø> (ø)
lib/puppet/provider/postgresql_conf/parsed.rb	100.00% <ø> (ø)
.../puppet/provider/postgresql_conn_validator/ruby.rb	80.00% <ø> (ø)
lib/puppet/type/postgresql_conf.rb	93.33% <ø> (ø)
lib/puppet/type/postgresql_conn_validator.rb	100.00% <ø> (ø)
lib/puppet/type/postgresql_replication_slot.rb	100.00% <ø> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b816e...c73a37b. Read the comment docs.

[DavidS]

The rhel-7, puppet7-nightly failure is IAC-1420, so we can ignore that and get this merged and released on Monday.

[ekohl]

I love it when you have more functionality with less code. I also hate it when code tries to join commands when you can actually pass an array of arguments. Big 👍 for this direction.

[ekohl]

Not sure if this introduced it, but in another module I started to see:

  Warning: /Postgresql_psql[ALTER ROLE jiraadm ENCRYPTED PASSWORD ****]: Unable to mark 'unless' as sensitive: unless is a parameter and not a property, and cannot be automatically redacted.

[vchepkov]

Warning: /Postgresql_psql[ALTER ROLE puppetdb ENCRYPTED PASSWORD ****]: Unable to mark 'unless' as sensitive: unless is a parameter and not a property, and cannot be automatically redacted.

[vchepkov]

@DavidS , I think unless can't be Sensitive, same as only_if, btw
https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/manifests/server/role.pp#L136

[smortex]

@ekohl @vchepkov I just opened #1249 to track this issue.

[ekohl]

#1253 is another regression I found with this PR.