Fix postgresql::sql task when password is not set #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @smortex for your contribution. |
Codecov Report
@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
+ Coverage 65.81% 66.18% +0.37%
==========================================
Files 14 14
Lines 351 349 -2
==========================================
Hits 231 231
+ Misses 120 118 -2
Continue to review full report at Codecov.
|
When password is not set, `{ 'PGPASSWORD' => password } unless
password.nil?` evaluates to `nil`, setting `env_hash` to `nil`.
`nil` is then passed as the first argument of `Open3.capture3` which
result in an exception:
```
/opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:213:in `spawn': no implicit conversion of nil into String (TypeError)
from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:213:in `popen_run'
from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:101:in `popen3'
from /opt/puppetlabs/puppet/lib/ruby/2.7.0/open3.rb:281:in `capture3'
from /opt/puppetlabs/mcollective/tasks-spool/899e9e0635bb53f1a09b4716548ff69f/files/sql.rb:13:in `get'
from /opt/puppetlabs/mcollective/tasks-spool/899e9e0635bb53f1a09b4716548ff69f/files/sql.rb:27:in `<main>'
```
Make sure `env_hash` is always a hash to fix this issue.
|
Thanks @smortex . We have timeout issues on centos 8 for travis. We have opened a ticket for the issue. Will be disabling them till the issue is sorted. So that it wont hold any PRS. Thanks for your contribution. |
sheenaajay
approved these changes
Feb 1, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
Fix postgresql::sql task when password is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When password is not set,
{ 'PGPASSWORD' => password } unless password.nil?evaluates tonil, settingenv_hashtonil.nilis then passed as the first argument ofOpen3.capture3whichresult in an exception:
Make sure
env_hashis always a hash to fix this issue.