Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contrib package name under debian 10 #1188

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fix contrib package name under debian 10 #1188

merged 2 commits into from
Sep 24, 2020

Conversation

neomilium
Copy link
Contributor

@neomilium neomilium commented Aug 27, 2020

Under Debian Buster, when we use only debian repo (ie. without using postgresql repo), the PostgreSQL contrib package postgresql-contrib-11 does not exist, only postgresql-contrib is available.

This PR fixes the wrong package name.

Note: Without this fix patch, module usage does not fail during puppet run, instead it notices the following message every run:

Notice: /Stage[main]/Postgresql::Server::Contrib/Package[postgresql-contrib]/ensure: created (corrective)

IMHO, this behavior is due to some magic done by apt, here the log when I run manually the install with the wrong package name:

$ sudo apt install postgresql-contrib-11
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Note, selecting 'postgresql-11' instead of 'postgresql-contrib-11'
postgresql-11 is already the newest version (11.7-0+deb10u1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

@neomilium neomilium requested a review from a team as a code owner August 27, 2020 15:39
@puppet-community-rangefinder
Copy link

postgresql::params is a class

Breaking changes to this file MAY impact these 3 modules (near match):

This module is declared in 71 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sanfrancrisko
Copy link
Contributor

Thanks for this fix @neomilium and for the detailed explanation of the issue. This change LGTM!

Could I ask if you could rebase your branch with puppetlabs:main - I tried to do this to pull in a workaround for the current failing CI tests, but I do not have permission to push to your fork.

The tests will automatically kick off again and then I'll merge when we've got the green light 😃

@neomilium
Copy link
Contributor Author

@sanfrancrisko Branch rebased, have fun!

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@648c135). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1188   +/-   ##
=======================================
  Coverage        ?   65.81%           
=======================================
  Files           ?       14           
  Lines           ?      351           
  Branches        ?        0           
=======================================
  Hits            ?      231           
  Misses          ?      120           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648c135...baa0091. Read the comment docs.

@sanfrancrisko sanfrancrisko merged commit b78a2c2 into puppetlabs:main Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants