Allow usage of PUBLIC role

[Vampouille]

Re-open #1003 with a new unit test

To generate this kind of query:

REVOKE CONNECT ON DATABASE database1 FROM PUBLIC;

I created following puppet code:

postgresql::server::database_grant { 'revoke connect on database1':
    ensure => 'absent',
    db => 'database1',
    privilege => 'CONNECT',
    role => 'PUBLIC',
}

This generate following error:

Error: /Stage[main]/Profile::Postgresql_gis/Postgresql::Server::Grant[revoke ALL on schema public to public:]/Postgresql_psql[grant:revoke ALL on schema public to public:]: Could not evaluate: Error evaluating 'unless' clause, returned pid 7360 exit 1: 'ERROR:  role "PUBLIC" does not exist

because PUBLIC is a "implicit" role and is not listed in pg_roles table.

To fix this I modify query that test if role exists.

[puppet-community-rangefinder]

postgresql::server::grant is a type

The enclosing module is declared in 51 of 578 indexed public Puppetfiles.

Breaking changes to this file WILL impact these modules (exact match):

• landcareresearch-ckan

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[Vampouille]

@david22swan @raphink helped me to add a unit test in this PR. Do you also need acceptance tests or is it ok for you ?

[Vampouille]

Some tests are broken since the last commit, I will try to fix it.

[Vampouille]

@david22swan Acceptance tests are fixed. Can you take a look at this PR ?