Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate REFERENCE.md file with strange unicode character at end of filename #1108

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

nudgegoonies
Copy link
Contributor

The file is duplicated but they have differences:
REFERENCE.md
REFERENCE.md\342\200\202
I deleted the additional added one with the strange unicode character at the end of filename. But maybe the original committer must check what version is the one to use @tphoney

@nudgegoonies nudgegoonies requested a review from a team as a code owner October 7, 2019 12:00
@tphoney
Copy link
Contributor

tphoney commented Oct 7, 2019

Thanks @nudgegoonies !!
great catch, i thought i was missing something, and i did.

@tphoney tphoney merged commit 1a17684 into puppetlabs:master Oct 7, 2019
@tphoney
Copy link
Contributor

tphoney commented Oct 7, 2019

@nudgegoonies the docs will be re-generated anyway when we next release the module.

@DavidS
Copy link
Contributor

DavidS commented Jan 10, 2020

Upgraded to bugfix, as the duplicate file can cause issues on PE LTS 2018.1 and was released as part of 6.2.0:

2020-01-09T02:25:31.353Z ERROR [clojure-agent-send-off-pool-16] [p.e.s.f.file-sync-storage-core] Fatal error during file sync commit, requesting shutdown.
java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters: /etc/puppetlabs/code-staging/environments/production/modules/postgresql/REFERENCE.md???

(introduced in 743d502, reported on slack by Laura Macchi; filed https://tickets.puppetlabs.com/browse/PDK-1587 to avoid this in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants