MODULES-8616 Check for permissions to be present on all tables, not j…

[wimvr]

Check for permissions to be present on all tables, not just one

[puppet-community-rangefinder]

postgresql::server::grant is a type

that may have no external impact to Forge modules.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[lionce]

Hello @wimvr ,

Thank you for your contribution! :)
The acceptance tests are failing on sles-11-x86_64. Here is our configuration

Error: Execution of '/usr/bin/zypper --quiet install --auto-agree-with-licenses --no-confirm postgresql91-server' returned 104: Problem retrieving the repository index file for service 'spacewalk':
17:11:16 [|] This client is not registered to any spacewalk server.
17:11:16
17:11:16 No provider of 'postgresql91-server' found.
17:11:16 Error: /Stage[main]/Postgresql::Server::Install/Package[postgresql-server]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/bin/zypper --quiet install --auto-agree-with-licenses --no-confirm postgresql91-server' returned 104: Problem retrieving the repository index file for service 'spacewalk':
17:11:16 [|] This client is not registered to any spacewalk server.

--- HOSTS: sles11-64-1: pe_dir: pe_ver: pe_upgrade_dir: pe_upgrade_ver: platform: sles-11-x86_64 packaging_platform: sles-11-x86_64 template: sles-11-x86_64 hypervisor: vmpooler roles: - agent - default redhat7-64-1: pe_dir: pe_ver: pe_upgrade_dir: pe_upgrade_ver: platform: el-7-x86_64 packaging_platform: el-7-x86_64 template: redhat-7-x86_64 hypervisor: vmpooler roles: - agent - master - database - dashboard CONFIG: nfs_server: none consoleport: 443 pooling_api: http://vmpooler.delivery.puppetlabs.net/

Just put this into default nodeset and run acceptance tests with your changes. If you need any help, please let me know!

Cheers!

[wimvr]

Hello @lionce,
I'm not sure, but looking at the error I would say there is a problem installing postgres91-server on sles-11. As I only changed a query, I doubt there is a relation. Can you please have a look and give me some hints what I should do different?
Cheers,
Wim

[lionce]

Hello @wimvr ,

Yes, it's a bit strange, because the updates are working on different platforms and failing just on this one (on installation - I believe it's a permission issue). Without your changes everything is passing. I'll take a deeper look on it! I'll come back to you as soon as possible :) Thanks!

Cheers

[lionce]

Hello @wimvr ,

I found the issue. No provider of 'postgresql91-server' found. It needs to be updated to a newer version:. it worked with postgresql94-server'. I'll inform you when it's fixed on github. thank you for your patience!

Cheers!

[lionce]

Hello @wimvr ,

Sorry for closing this PR. I've closed it and reopened it just to pick up the latest changes on tests. Now you can check the results on travis.

Cheers!

[sheenaajay]

@wimvr Thanks for submitting the PR.
The changes are incorporated in the following PR which is merged
#1096
Please let us know if that works.
@georgehansper Thank you.

[sheenaajay]

@wimvr Feel free to reopen the PR if the fix doesn't work (PR #1096)

[sheenaajay]

Thank you @wimvr for your contribution.