(maint) remove inconsistent extra variable #1044
Conversation
This just removes a variable that was confusing because of how inconsistently it was used, and didn't really appear to be adding much value anyway.
postgresql::server is a classBreaking changes to this file WILL impact these modules (exact match):
Breaking changes to this file MAY impact these modules (near match):
These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report. Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only. |
|
@binford2k Do you have a specific reason for wanting this?? I just worry that it is being used external users and as such would break their code. |
|
Since it's a static string and the variable name is longer than the value it contains, I think the probability that it's being used externally is astronomically small. It's also an internal variable, not part of any public API. That said, if you were highly concerned about that, you could grep each repo listed in the rangefinder report for In reality, I just wanted a trivial & low risk change to a class used by a lot of people for rangefinder testing. ;-) |
|
@binford2k If there wasn't a real reason behind the change I think I'll leave it as is just in case. |
(maint) remove inconsistent extra variable
This just removes a variable that was confusing because of how
inconsistently it was used, and didn't really appear to be adding much
value anyway.