Remove deprecated option expire_logs_days from default config #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraenki
requested review from
alexjfisher,
bastelfreak and
a team
as code owners
|
|
fraenki
changed the title
bastelfreak
approved these changes
Mar 13, 2024
Ramesh7
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The option
expire_logs_daysis deprecated and should no longer be used. This PR removes it from the default configuration.Additional Context
This change should only have a minor effect on existing installations. Old versions of MySQL (5.7) will fallback to their internal default value of
expire_logs_days. Newer versions (MySQL 8.0) will probably already use the new optionbinlog_expire_logs_seconds.This removes the following warning from MySQL's log:
Related Issues (if any)
none
Checklist
puppet apply)