Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major adjustments for current code style #607

Merged
merged 5 commits into from
May 11, 2020
Merged

major adjustments for current code style #607

merged 5 commits into from
May 11, 2020

Conversation

crazymind1337
Copy link
Contributor

I have made a general linting for all manifests.

  • lint and indent for all class and defined types parameters
  • fixed several data type usages
  • lint and indent of all manifests
  • dropped usage of legacy facts
  • switched to puppet strings layout
    • added missing parameter to list (without description)
    • removed dropped parameter from list
    • generated new REFERENCE.md

@crazymind1337 crazymind1337 requested a review from a team as a code owner May 7, 2020 10:06
@crazymind1337 crazymind1337 changed the title Fix/linting general linting of manifests May 7, 2020
@crazymind1337
Copy link
Contributor Author

I want to add support for Ubuntu focal fossa, but I did not like the code style, so I adjusted it.

@crazymind1337 crazymind1337 marked this pull request as draft May 7, 2020 10:29
@crazymind1337
Copy link
Contributor Author

Fixing those rspec error for migrated $facts is quite a mess.

@crazymind1337 crazymind1337 changed the title general linting of manifests major adjustments for current code style May 8, 2020
@crazymind1337 crazymind1337 marked this pull request as ready for review May 8, 2020 04:16
david22swan
david22swan approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit 915bf8a into puppetlabs:master May 11, 2020
@david22swan
Copy link
Member

@crazymind1337 Thanks for the work :)

@genebean
Copy link
Contributor

Nice work @crazymind1337! I saw you mention this in slack - always nice to see people take the time to make things match current standards :)

@crazymind1337 crazymind1337 deleted the fix/linting branch May 13, 2020 08:23
@crazymind1337
Copy link
Contributor Author

Nice work @crazymind1337! I saw you mention this in slack - always nice to see people take the time to make things match current standards :)

Thats the way open source is working ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazymind1337 @david22swan @genebean @daianamezdrea