Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9193) Revert part of MODULES-9177 #490

Merged
merged 1 commit into from
May 30, 2019

Conversation

eimlav
Copy link
Contributor

@eimlav eimlav commented May 30, 2019

The changes introduced in MODULES-9177 modified the behaviour of docker
installs using older versions. The first part of the modified regex ensured
that the correct repository was used. As such I have reverted it but
left the rest of the changes to ensure that non 17.y.z versions use the
correct repo.

@eimlav eimlav added the bugfix label May 30, 2019
The changes introduced in MODULES-9177 modified the behaviour of docker
installs using older versions. The first part of the modified regex ensured
that the correct repository was used. As such I have reverted it but
left the rest of the changes to ensure that non 17.y.z versions use the
correct repo.
@eimlav
Copy link
Contributor Author

eimlav commented May 30, 2019

Adhoc ran successfully:

Screen Shot 2019-05-30 at 16 49 35

@sheenaajay sheenaajay merged commit 6fee44d into puppetlabs:master May 30, 2019
@eimlav eimlav deleted the modules-9193 branch May 31, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants