(MODULES-5898) add admin_only to chocolateysource #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is running through adhoc in Jenkins now to validate the new acceptance tests. |
michaeltlombardi
changed the title
README.md
Outdated
|
|
||
| Option to specify whether this source should visible to administrators only. | ||
|
|
||
| Requires at least Chocolatey v0.10.8 to set and at least Chocolatey Business Edition v1.12.2 to take effect. |
There was a problem hiding this comment.
"Chocolatey for Business (C4B)" not "Chocolatey Business Edition"
I would reorder this a bit: "Requires Chocolatey for Business (C4B) v1.12.2+ and at least Chocolatey v0.10.8 for the setting to be respected." That way the commercial edition requirement is noted first.
README.md
Outdated
|
|
||
| (**Property**: This parameter represents a concrete state on the target system.) | ||
|
|
||
| Option to specify whether this source should visible to administrators only. |
There was a problem hiding this comment.
Administrators here being "Windows user accounts in the Administrators group", just so there is no confusion about what is meant here.
michaeltlombardi
changed the title
Prior to this commit the `chocolateysource` type and provider did not support the option to specify the `--admin-only` flag when managing a source. This option causes Chocolatey to markthe source as visible only to admins and was introduced in Chocolatey `0.10.8`. This commit adds the `admin_only` property to the type and provider of `chocolateysource` to ensure that this property can be configured on versions which support it. This commit also updates the README documentation and CHANGELOG, as well as providing new unit and acceptance tests and updating any unit and acceptance tests which should include the new setting.
RandomNoun7
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the
chocolateysourcetype and provider didnot support the option to specify the
--admin-onlyflag whenmanaging a source. This option causes Chocolatey to markthe source
as visible only to admins and was introduced in Chocolatey
0.10.8.This commit adds the
admin_onlyproperty to the type andprovider of
chocolateysourceto ensure that this propertycan be configured on versions which support it.
This commit also updates the README documentation and CHANGELOG,
as well as providing new unit and acceptance tests and updating
any unit and acceptance tests which should include the new
setting.