(MODULES-8081): add support for hkps:// protocol in apt::key

[simondeziel]

Add hkps:// to the list of protocols supported by apt::key
(hkp://, http:// and https://).

[simondeziel]

https://travis-ci.org/puppetlabs/puppetlabs-apt/jobs/439464775 and https://travis-ci.org/puppetlabs/puppetlabs-apt/jobs/439464776 are failing because hpks started being supported in newer Debian/Ubuntu releases. I'm not sure how to update the tests to allow hkps:// only on recent distro versions.

[david22swan]

@simondeziel I think the best thing to do in this instance is to but an exception around the test's so that their only run on the machines that support hkps, and add a note into the readme which which reflects this limitation.
Maybe put an error message into the manifest that triggers if you try to use hkps on an unsupported machine.

[david22swan]

@simondeziel Your changes are currently failing on a syntax check, heres the test output:

Offenses:
spec/acceptance/apt_key_provider_spec.rb:481:1: C: Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
if fact('operatingsystem') =~ %r{Ubuntu} and fact('operatingsystemrelease') =~ %r{^18\.04} ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/acceptance/apt_key_provider_spec.rb:481:42: C: Style/AndOr: Use && instead of and. (https://github.com/bbatsov/ruby-style-guide#no-and-or-or)
if fact('operatingsystem') =~ %r{Ubuntu} and fact('operatingsystemrelease') =~ %r{^18\.04}
                                         ^^^

[david22swan]

@simondeziel Also, the documentation in the key.pp file still need's to be updated. Everything else looks good to me though.

[simondeziel]

@david22swan, I don't understand how to fix this:

spec/acceptance/apt_key_provider_spec.rb:481:1: C: Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
if fact('operatingsystem') =~ %r{Ubuntu} && fact('operatingsystemrelease') =~ %r{^18\.04} ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Could you walk me through it or point me to a style guide, please? Thanks

[simondeziel]

@david22swan, please let me know if something's missing.

[david22swan]

[david22swan]

@simondeziel runs clean on adhoc so i'm happy to merge. Sorry for the wait, was out on holiday.