Revert "(MODULES-6408) - Fix dirmngr install failing"

[eimlav]

Reverts #801. Reverting as this is causing failures in Puppet DB.

[rvdh]

This revert actually breaks the APT module for me:

Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for client1.vagrant.lan
Info: Applying configuration version '1538485599'
Error: Failed to apply catalog: Found 1 dependency cycle:
(Package[dirmngr] => Class[Apt] => Package[dirmngr])
Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz
root@client1:~#

After commenting the ensure_packages line:

  # manage pins if present
  if $pins {
    create_resources('apt::pin', $pins)
  }

  # required for adding GPG keys on Debian 9 (and derivatives)
  #ensure_packages(['dirmngr'])
}

The manifest works again:

root@client1:~# puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for client1.vagrant.lan
Info: Applying configuration version '1538485760'
Notice: /Stage[main]/Avisi_restore/Service[restic-restore]/ensure: ensure changed 'stopped' to 'running'
...
Notice: /Stage[main]/Avisi_localpostfix/Postfix::Hash[/etc/postfix/mydestinations]/Postfix::Map[/etc/postfix/mydestinations]/File[postfix map /etc/postfix/mydestinations.db]/mode: mode changed '0600' to '0644'
Notice: Applied catalog in 168.27 seconds```

[eimlav]

Hey @rvdh . Would it be possible for you to open a ticket over at https://tickets.puppetlabs.com along with the details of your environment and your error so that we can document the issue? Thanks!