Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt/params: Remove unused LSB facts #610

Merged
merged 1 commit into from
Jun 7, 2016
Merged

apt/params: Remove unused LSB facts #610

merged 1 commit into from
Jun 7, 2016

Conversation

daenney
Copy link

@daenney daenney commented Jun 5, 2016

These facts aren't used anywhere in the APT module and at least lsbminordistrelease doesn't seem to be set at all anymore in recent versions of Puppet. This causes the following warning to show up on Puppet 4.3:

Warning: Undefined variable 'lsbminordistrelease';
   (file & line not available)

On 4.5 we get the slightly more helpful:

Warning: Unknown variable: '::lsbminordistrelease'. at /etc/puppetlabs/code/environments/production/modules/apt/manifests/params.pp:15:32

@daenney daenney added the bugfix label Jun 5, 2016
@daenney
Copy link
Author

daenney commented Jun 6, 2016

@bmjen If you're looking at apt PRs anyway, here's another 😄.

@bmjen
Copy link

bmjen commented Jun 7, 2016

Thanks @daenney !

@bmjen bmjen merged commit 5476d90 into master Jun 7, 2016
@daenney daenney deleted the unused-lsb branch June 7, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants