Add support for parameter trusted MODULES-1658 #407
Conversation
* Add support for paramater trusted, valid options are 'true' and false. defaults to false. True sets the value to trusted=yes. trusted=yes can be set to indicate that packages from this source are always authenticated even if the Release file is not signed or the signature can't be checked. * Update documentation
|
I think the master branch is currently broken, which is why my travis CI build is failing :( |
mkrakowitzer
changed the title
|
Yes master is broken (though it seems to be due to a CI environment change rather than anything committed to master). There are 2 pull requests in the queue that fix the problem. Once one of those gets merged you can rebase your change on top of latest master. |
|
I understand the reason for wanting this but I hate that apt supports this faking of authenticity. It seems the CI problems where resolved. Could you rebase and try this again? |
…into f3792625/trusted_param
|
@daenney ok, rebased. Im not in favour of it either, its a long story why I need this which I wont bore you with. |
| @@ -55,6 +55,7 @@ | |||
| 'key_source' => 'http://apt.puppetlabs.com/pubkey.gpg', | |||
| 'pin' => '10', | |||
| 'architecture' => 'x86_64', | |||
| 'trusted' => true, | |||
There was a problem hiding this comment.
Why are we modifying an existing test?
There was a problem hiding this comment.
The test is called 'no defaults', if I left it then it would be a default.
|
@mhaskel @cyberious Comments? |
|
@daenney looks sane to me |
Add support for parameter trusted MODULES-1658
|
Thank you for your contribution! 'till next time! |
trusted=yes can be set to indicate that packages from this source are always authenticated even if the Release file is not signed or the signature can't be checked.