1.5.3 backports #340
Merged
1.5.3 backports #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation would overwrite the file name and potentially include characters that would cause apt to ignore the pref file
Conflicts: Gemfile
Gotta love the difference between Ruby 1.8.7 not caring and every subsequent version exploding.
- The default for $proxy_host is undef - apt considers $proxy_set to be absent if $proxy_host is undef - apt::ppa considers proxy_env to be empty if $proxy_host is false or '' This results in apt::ppa to consider $proxy_host to be set when the default undef is used breaking ppa resources because $proxy_env becomes: [http_proxy=http://:8080, https_proxy=http://:8080] Fix this by making both apt and apt::ppa consider $proxy_host to be unset when it is any of false, '', or undef.
New fact was added that matched a regex breaking the always_apt_update tests. Updated the tests to check for the apt_update exec, not just the string apt_update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked bugfixes from master for a requested 1.5.3 release.