Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - (GH-iac-334) Remove Support for Ubuntu 14.04 #1023

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

david22swan
Copy link
Member

(GH-iac-334) Remove Support for Ubuntu 14.04
pdk version: 2.2.0

Verified

This commit was signed with the committer’s verified signature.
aroralanuk Kunal Arora
@david22swan david22swan requested a review from a team as a code owner March 23, 2022 16:22
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/puppetlabs/puppetlabs-apt/search?q=14.04&type= IMO the 14.04 specific code needs to be removed as well

@david22swan david22swan reopened this Mar 24, 2022
@david22swan
Copy link
Member Author

All compatibility code will be removed from the module in a separate pr. This one is meant to be a quick merge to remove support with followup prs to follow t strip away the excess code so that we can have support dropped immedaitly without needing to wait for each module to be given the attention needed to safely remove all compatible code.

@LukasAud LukasAud merged commit 90d3bc5 into main Mar 24, 2022
@LukasAud LukasAud deleted the pdksync_GH-iac-334/main/remove_ubuntu_14.04_support branch March 24, 2022 14:04
@david22swan
Copy link
Member Author

Followup compatability pr is up: #1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants