Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex for ppa name issues with dotted versions #1057

Closed
gsperry2011 opened this issue Aug 25, 2022 · 1 comment · Fixed by #1058
Closed

Regex for ppa name issues with dotted versions #1057

gsperry2011 opened this issue Aug 25, 2022 · 1 comment · Fixed by #1058

Comments

@gsperry2011
Copy link

Describe the Bug

This is a valid PPA name from the MAAS documentation: ppa:maas/3.1 but does not pass the regex validation in ppa.pp due to the . in the version number 3.1.

Found from the docs here: https://maas.io/docs/how-to-install-maas

Expected Behavior

It should pass regex checks and be added as normal

Steps to Reproduce

Steps to reproduce the behavior:
call this resource:

  apt::ppa { "ppa:maas/3.1": }

Environment

This should be effecting all versions

Additional Context

Issue is here: https://github.com/puppetlabs/puppetlabs-apt/blob/main/manifests/ppa.pp#L43
@elfranne
Copy link

The change was introduced in #1052 by @chelnak

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Invalid PPA name: ppa:vbernat/haproxy-2.6 (file: /etc/puppetlabs/code/environments/testapt/modules/apt/manifests/ppa.pp, line: 44, column: 5)

LukasAud added a commit that referenced this issue Aug 30, 2022
@LukasAud
(ISSUE-1057)Regex fix to allow dotted resources
4edbcb0 
Prior to this commit, one of our recent module updates introduced a
regex validation step for the resource names in our ppa.pp manifest
which would raise an issue if a valid resource name contained a dot (.).

This commit aims to slightly adjust the regex validation so that it
allows for dotted resource names. This PR should fix issue #1057.
@LukasAud LukasAud mentioned this issue Aug 30, 2022
Merged
LukasAud added a commit that referenced this issue Aug 31, 2022
@LukasAud
(GH-1057) Regex fix to allow dotted resources
5a2e5c0 
Prior to this commit, one of our recent module updates introduced a
regex validation step for the resource names in our ppa.pp manifest
which would raise an issue if a valid resource name contained a dot (.).

This commit aims to slightly adjust the regex validation so that it
allows for dotted resource names. This PR should fix issue #1057.
@pmcmaw pmcmaw linked a pull request Aug 31, 2022 that will close this issue
(GH-1057) Regex fix to allow dotted resources #1058
Merged
@pmcmaw pmcmaw closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-1057) Regex fix to allow dotted resources puppetlabs/puppetlabs-apt
3 participants
@elfranne @pmcmaw @gsperry2011