Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling default vhosts under 2.4 #909

Merged
merged 1 commit into from
Nov 4, 2014
Merged

allow disabling default vhosts under 2.4 #909

merged 1 commit into from
Nov 4, 2014

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Oct 22, 2014

when disabling the default vhost(s) under 2.4, there's nothing to
include in $sites-enabled/, which causes the following error:

The apache2 configtest failed.
Output of config test was:
apache2: Syntax error on line 46 of /etc/apache2/apache2.conf: No
matches for the wildcard '*' in '/etc/apache2/sites-enabled', failing
(use IncludeOptional if required)
Action 'configtest' failed.
The Apache error log may have more information.

by using IncludeOptional (as recommended), we allow the use of httpd as
simple web server, with single purpose configuration, without having to
define a (default) vhost.

when disabling the default vhost(s) under 2.4, there's nothing to
include in $sites-enabled/, which causes the following error:

    The apache2 configtest failed.
    Output of config test was:
    apache2: Syntax error on line 46 of /etc/apache2/apache2.conf: No
    matches for the wildcard '*' in '/etc/apache2/sites-enabled', failing
    (use IncludeOptional if required)
    Action 'configtest' failed.
    The Apache error log may have more information.

by using IncludeOptional (as recommended), we allow the use of httpd as
simple web server, with single purpose configuration, without having to
define a (default) vhost.
@igalic
Copy link
Contributor Author

igalic commented Oct 26, 2014

@hunner, @mhaskel ping

underscorgan pushed a commit that referenced this pull request Nov 4, 2014
allow disabling default vhosts under 2.4
@underscorgan underscorgan merged commit 1101dae into puppetlabs:master Nov 4, 2014
@underscorgan
Copy link
Contributor

thanks @igalic!

@igalic igalic deleted the no_default_vh_24 branch November 7, 2014 14:06
@igalic
Copy link
Contributor Author

igalic commented Nov 7, 2014

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants