-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set multiple ProxyPassReverse directives #793
Allow to set multiple ProxyPassReverse directives #793
Conversation
ProxyPassReverse <%= proxy['url'] %> | ||
<% else %> | ||
<% proxy['reverse_urls'].each do |rurl| %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be wrapped in an array like Array(proxy['reverse_urls']).each do |rurl|
so it doesn't crash if a single reverse URL is passed.
This requires README updates and test coverage. |
@mhaskel Done :-) |
<% Array(proxy['reverse_urls']).each do |reverse_url| %> | ||
ProxyPassReverse <%= reverse_url %> | ||
<% end %> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be -%>
@mhaskel changes done |
@roidelapluie I'm seeing test failures when I run the unit tests locally:
Also, we fixed the travis-ci issues that were in master, so if you rebase it will be easier to see that the tests were fixed :) |
@mhaskel this is fixed and rebased now |
@roidelapluie please also squash your commits down to one. (It's nice for git-bisect if every commit passes tests) |
This commit allows you to add an array or a string as a proxy_pass['reverse_url'] parameter. Useful when used with mod_balancer.
@igalic done |
…PassReverse_directives Allow to set multiple ProxyPassReverse directives
@roidelapluie thanks for the contribution! |
Useful when used with proxy balancers