Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Lets talk about before merging! - Rspec3 conversion. #763

Merged
merged 4 commits into from
Jun 26, 2014
Merged

WIP: Lets talk about before merging! - Rspec3 conversion. #763

merged 4 commits into from
Jun 26, 2014

Conversation

apenney
Copy link
Contributor

@apenney apenney commented Jun 6, 2014

No description provided.

Ashley Penney added 4 commits June 6, 2014 10:08
This conversion is done by Transpec 2.2.1 with the following command:
    transpec spec/classes

* 384 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 47 conversions
    from: it { should_not ... }
      to: it { is_expected.not_to ... }

* 3 conversions
    from: obj.should
      to: expect(obj).to

* 2 conversions
    from: == expected
      to: eq(expected)

For more details: https://github.com/yujinakayama/transpec#supported-conversions
This conversion is done by Transpec 2.2.1 with the following command:
    transpec spec/defines

* 65 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 9 conversions
    from: it { should_not ... }
      to: it { is_expected.not_to ... }

For more details: https://github.com/yujinakayama/transpec#supported-conversions
This conversion is done by Transpec 2.2.1 with the following command:
    transpec spec/unit

* 4 conversions
    from: obj.should
      to: expect(obj).to

* 3 conversions
    from: == expected
      to: eq(expected)

For more details: https://github.com/yujinakayama/transpec#supported-conversions
This conversion is done by Transpec 2.2.1 with the following command:
    transpec spec/acceptance

* 234 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 58 conversions
    from: obj.should
      to: expect(obj).to

* 33 conversions
    from: =~ /pattern/
      to: match(/pattern/)

* 20 conversions
    from: it { should_not ... }
      to: it { is_expected.not_to ... }

* 18 conversions
    from: == expected
      to: eq(expected)

* 1 conversion
    from: obj.should_not
      to: expect(obj).not_to

For more details: https://github.com/yujinakayama/transpec#supported-conversions
apenney pushed a commit that referenced this pull request Jun 26, 2014
WIP:  Lets talk about before merging! - Rspec3 conversion.
@apenney apenney merged commit 23818ac into puppetlabs:master Jun 26, 2014
@igalic
Copy link
Contributor

igalic commented Jun 30, 2014

no one seems to have wanted to talked with you about this :|

traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
…-run

Duplicate declaration statement: docker_params_changed is already declared
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants