add logroot_mode parameter #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this new parameter do? Can you please document it in README.md? Also, please add spec/acceptance tests! |
|
Hi Igor, This parameter allows people to set the mode on the logroot directory. I've set the default to undef with the assumption that it will not change the default mode set by the installed package (0700 on RedHat, 0750 on Debian). spectest was already included, unfortunately I'm not sure how to write the acceptance test. The usecase here is that we want to allow ssh users read access to the logfiles. So mode 0755 on the /var/log/httpd directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.