Add new params to apache::mod::mime class #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adds $mime_support_package and $mime_types_config parameters to class `apache::mod::mime`. Their purpose is following: - $mime_support_package - install this package, as it provides mime.conf file (definition of mime types used by mod_mime), - $mime_types_config - used to substitute TypesConfig in mod/mime.conf.erb template. This PR was created in order to plit puppetlabs#342 into smaller parts to make review process easier, see puppetlabs#342 (comment)
apenney
pushed a commit
that referenced
this pull request
Nov 8, 2013
Add new params to apache::mod::mime class
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
While the class docker::services already allowed arrays to be
specified for `publish` ports, it didn't handle this correctly since
this array was simply converted to a string and passed onto Docker,
like so:
--publish '["80:80", "443:443"]'
To correctly publish multiple ports, the `--publish` parameter has to
be called specified for each port.
--publish '80:80' --publish '443:443'
This patch also introduces a new spec test to check this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds $mime_support_package and $mime_types_config parameters to class
apache::mod::mime. Their purpose is following:$mime_support_package- install this package, as it provides mime.conffile (definition of mime types used by mod_mime),
$mime_types_config- used to substitute as TypesConfig inmod/mime.conf.erb template.
This PR was created in order to plit #342 into smaller parts to make review process easier, see #342 (comment)