Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Allow and ExtendedStatus support to mod_status (rebase of #419) #446

Merged
merged 1 commit into from
Nov 11, 2013

Conversation

dbeckham
Copy link
Contributor

@dbeckham dbeckham commented Nov 8, 2013

This is a rebase of 555e0f7 submitted in #419 against the most recent mod_status changes. I also added class docs and cleaned up the testing a bit as well as added a couple of extra test cases. rake spec finishes cleanly.

_Commit Message:_

I've extended the apache::mod::status class to accept an $allow_from
parameter similar to the existing apache::mod::info class, as well as
added an $extended_status parameter to control the ExtendedStatus
directive.

Added module docs and full testing support as well as updated the
README.md to indicate that the status class accepts additional
parameters.

I've extended the apache::mod::status class to accept an `$allow_from`
parameter similar to the existing apache::mod::info class, as well as
added an `$extended_status` parameter to control the ExtendedStatus
directive.

Added module docs and full testing support as well as updated the
README.md to indicate that the status class accepts additional
parameters.
@igalic
Copy link
Contributor

igalic commented Nov 8, 2013

rake spec is, indeed passing, but right now rake spec:system is not

Failures:

  1) apache::default_mods class no default mods should apply with no errors
     Failure/Error: [0,2].should include(r.exit_code)


     # ./spec/system/default_mods_spec.rb:24:in `block (4 levels) in <top (required)>'
     # ./spec/system/default_mods_spec.rb:23:in `block (3 levels) in <top (required)>'

  2) apache::default_mods class no default mods Service "httpd"
     Failure/Error: it { should be_running }
       ps aux | grep -w -- httpd | grep -qv grep
     # ./spec/system/default_mods_spec.rb:31:in `block (4 levels) in <top (required)>'

  3) apache::mod::event class running puppet code should work with no errors
     Failure/Error: r.exit_code.should_not == 1


     # ./spec/system/prefork_worker_spec.rb:24:in `block (4 levels) in <top (required)>'
     # ./spec/system/prefork_worker_spec.rb:23:in `block (3 levels) in <top (required)>'

Finished in 17 minutes 25 seconds
62 examples, 3 failures

Failed examples:

rspec ./spec/system/default_mods_spec.rb:15 # apache::default_mods class no default mods should apply with no errors
rspec ./spec/system/default_mods_spec.rb:31 # apache::default_mods class no default mods Service "httpd"
rspec ./spec/system/prefork_worker_spec.rb:15 # apache::mod::event class running puppet code should work with no errors

@dbeckham
Copy link
Contributor Author

dbeckham commented Nov 8, 2013

Yes, I failed to actually run the system test. I'll correct the issue and push a combined change.

@apenney
Copy link
Contributor

apenney commented Nov 11, 2013

Don't worry, those spec errors are fixed in master.

apenney pushed a commit that referenced this pull request Nov 11, 2013
Add Allow and ExtendedStatus support to mod_status (rebase of #419)
@apenney apenney merged commit f97c340 into puppetlabs:master Nov 11, 2013
@dbeckham
Copy link
Contributor Author

Awesome, thanks for merging this.

@dbeckham dbeckham deleted the mod_status_allow_rebase branch November 12, 2013 21:59
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants