Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make directories examples real puppet DSL #253

Merged
merged 1 commit into from
Jul 16, 2013

Conversation

richardc
Copy link
Contributor

People don't read:

directory => [ { path => '/path/to/directory', <directive> => <value> } ],

as psuedo-code example instructing you on how to form an array of hashes, they
read them as puppet DSL examples that they can copy and paste into their
apache::vhost stanzas.

@hunner
Copy link
Contributor

hunner commented Jul 15, 2013

Awesome! This is much better.

One request before merging: could you please add docroot parameters to the examples, as this is still a required parameter (and must match at least one directories entry, iirc).

People don't read:

    directory => [ { path => '/path/to/directory', <directive> => <value> } ],

as psuedo-code example instructing you on how to form an array of hashes, they
read them as puppet DSL examples that they can copy and paste into their
apache::vhost stanzas.
@richardc
Copy link
Contributor Author

Sure, updated.

hunner added a commit that referenced this pull request Jul 16, 2013
make directories examples real puppet DSL
@hunner hunner merged commit e9d22e0 into puppetlabs:master Jul 16, 2013
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
Volumes acceptance test for Docker on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants