Simplify templates by reusing methods #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekohl Look's like your change may be causing some failures on Debian and Ubuntu |
|
I've submitted the first part as #2366. Once that's merged I'll rebase this and see where it fails. |
ekohl
force-pushed
the
simplify-templates
branch
2 times, most recently
from
e9e9acf to
a15e4b7
Compare
|
Rebased and pushed a fix in the WSGI template that I think was the cause for the failure. If this is green, it's ready to be merged. |
It's valid to call .sort on a hash and it'll sort by key. This means you don't need to perform an additional lookup when iterating and makes the code more readable.
david22swan
force-pushed
the
simplify-templates
branch
from
a15e4b7 to
0b70544
Compare
david22swan
approved these changes
Jan 16, 2023
|
@david22swan rebase passed. |
|
Apologies on the wait, this slipped my mind |
|
I've been there way too often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. Note I haven't tested this and will rely on CI and review to spot errors.