Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate definition of auth_basic-mod #2287

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix duplicate definition of auth_basic-mod #2287

merged 1 commit into from
Aug 10, 2022

Conversation

sircubbi
Copy link
Contributor

Pull-Request #2252 breaks the usage of auth_basic in a vhost, because the module is
declared twice:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Apache::Mod[auth_basic] is already declared at (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/default_mods.pp, line: 142); cannot redeclare (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/mod/auth_basic.pp, line: 7) (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/mod/auth_basic.pp, line: 7, column: 3) (file: /etc/puppetlabs/code/environments/module_updates/site-modules/rx_apache/manifests/vhost.pp, line: 336) on node ...

fix it by including the appropriate class in defaults_mods, instead of
just defining the module

PR 2252 breaks the usage of auth_basic in a vhost, because the module is
declared twice:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Apache::Mod[auth_basic] is already declared at (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/default_mods.pp, line: 142); cannot redeclare (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/mod/auth_basic.pp, line: 7) (file: /etc/puppetlabs/code/environments/module_updates/modules/apache/manifests/mod/auth_basic.pp, line: 7, column: 3) (file: /etc/puppetlabs/code/environments/module_updates/site-modules/rx_apache/manifests/vhost.pp, line: 336) on node ...

fix it by including the appropriate class in defaults_mods, instead of
just defining the module
@sircubbi sircubbi requested a review from a team as a code owner August 10, 2022 07:53
@puppet-community-rangefinder
Copy link

apache::default_mods is a class

that may have no external impact to Forge modules.

This module is declared in 174 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl added the bugfix label Aug 10, 2022
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank's for pushing this up :)

@david22swan david22swan merged commit 921de9e into puppetlabs:main Aug 10, 2022
@ekohl ekohl linked an issue Aug 17, 2022 that may be closed by this pull request
@mungo312
Copy link

mungo312 commented Aug 18, 2022

Hi, any chance to get a bugfix release to puppetforge soon ? For me going back to 7.0.0 is not an option after the major data type reworks done with this version.

@david22swan
Copy link
Member

Release is scheduled for today, so it should be out soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate declaration error after update to 8.0.0
5 participants