(MODULES-10712) Fix mod_ldap on RH/CentOS 5 and 6

[h-haaks]

#1913 changed ldap package to always be mod_ldap, but on rhel/centos 5 and 6 mod_ldap is in the httpd package and there is no mod_ldap package.

[puppet-community-rangefinder]

apache::params is a class

Breaking changes to this file WILL impact these 12 modules (exact match):

• xdrum-puppet
• brucem-ezpublish
• desalvo-bacula
• jlondon-phpmyadmin
• openstack-placement
• osc-openondemand
• openstack-keystone
• openstack-cinder
• openstack-ironic
• openstack-mistral
• openstack-manila
• openstack-zaqar

Breaking changes to this file MAY impact these 16 modules (near match):

• openstack-cloudkitty
• openstack-vitrage
• openstack-watcher
• openstack-sahara
• openstack-panko
• openstack-neutron
• openstack-aodh
• openstack-gnocchi
• openstack-octavia
• openstack-barbican
• openstack-magnum
• willdurand-bazinga
• openstack-tripleo
• openstack-heat
• camptocamp-catalog_diff
• ULHPC-passenger

This module is declared in 174 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[h-haaks]

Not really sure why acceptance is failing on el8...
Is #2040 causing this?

[sanfrancrisko]

@h-haaks Apologies - those test failures were indeed caused by #2040. Not quite sure what I was thinking, but that PR should have gone through a CI test run before being merged. For some reason it did not kick off the tests and I didn't pick up on that before merging, thinking it was all good to go.

I'm prep'ing a fix to puppetlabs:master in #2042 if you want to rebase and pull it in after

[h-haaks]

@sanfrancrisko I have pulled the last changes into StatensPensjonskasse:master and rebased StatensPensjonskasse:fix-mod_ldap-on-rhel6.
Still doesn't pass acceptance ... :(

[sanfrancrisko]

@h-haaks I'm seeing failures too on #2021 which I'm trying to fix up and push. There's been a bit of scope creep now and things have gotten a bit more complicated, but I'm hoping to have it merged to puppetlabs:master later today. I'll ping you when I do.

[sanfrancrisko]

@h-haaks If you rebase with puppetlabs:master now, I'm hoping that will resolve the test failures.

[sanfrancrisko]

Also, probably worth making you aware of #2021 - it shouldn't cause a conflict, but worth highlighting since the change is in a similar spot.

[codecov-commenter]

Codecov Report

Merging #2041 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2041   +/-   ##
=======================================
  Coverage   58.49%   58.49%           
=======================================
  Files          12       12           
  Lines         212      212           
=======================================
  Hits          124      124           
  Misses         88       88           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cde24f...cbef540. Read the comment docs.

[h-haaks]

@h-haaks If you rebase with puppetlabs:master now, I'm hoping that will resolve the test failures.

Thanks @sanfrancrisko now all tests are green :)
I have assigned https://tickets.puppetlabs.com/browse/MODULES-10712 to me and changed status to 'READY FOR REVIEW'

[sanfrancrisko]

@h-haaks The PR LGTM. I quickly tested locally with an acceptance test for a bit of extra sanity. I put up a PR with the test against your fork, if you wouldn't mind merging? https://github.com/StatensPensjonskasse/puppetlabs-apache/pull/1

After that, happy to merge 👍

Thanks again for the fix.

[h-haaks]

@h-haaks The PR LGTM. I quickly tested locally with an acceptance test for a bit of extra sanity. I put up a PR with the test against your fork, if you wouldn't mind merging? StatensPensjonskasse#1

After that, happy to merge 👍

Thanks again for the fix.

Merged and tested all green. Ready for merge @sanfrancrisko :)