Fix case of setting apache::mpm_module to false #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class yourself b/c you need to set params.
|
A similar pattern to https://github.com/MiamiOH/puppetlabs-apache/blob/7d43453293a54b0479efd753b3b6950d48d5890e/manifests/mod/cgid.pp was used. |
|
Thank you for your contribution, @edestecd |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Fix case of setting apache::mpm_module to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit: 0dcfa2a#diff-2c378354f8ec309dd88357170e38035d
Breaks a common setup of setting $::apache::mpm_module to false and declaring your own mpm module to set params etc. and results in the following error:
This restores that functionality while still maintaining the intent of the original commit.
The net effect should be the same, but it handles more cases better.