add paramter to set config file permissions

[timogoebel]

This PR adds an parameter file_mode to specify the desired permissions mode the config files are created with.

[jonnytdevops]

Hi There

The tests will need to be fixed before we can merge this.

Also, can you please state a business case where the default permissions are not acceptable?

Thanks

[timogoebel]

I think that the test failures are not related and already broken in master.

A business case for the parameter is quite common: one may need to pass hardening requirements from pci-dss, cis, ...
I can add this to the docs if you want...

On 18.01.2016, at 16:54, JT (Jonny) notifications@github.com wrote:

Hi There

The tests will need to be fixed before we can merge this.

Also, can you please state a business case where the default permissions are not acceptable?

Thanks

—
Reply to this email directly or view it on GitHub.

[timogoebel]

@jonnytpuppet: I just had another look at the acceptance test failures. Apache can not start because of

Invalid command 'FastCgiExternalServer', perhaps misspelled or defined by a module not included in the server configuration

This is definitely not related to the changes in this PR.

[jonnytdevops]

@timogoebel You are indeed correct, these failures are unrelated to your changes. @tphoney is working on apache internally to see if we can fix the current build, then we can look at merging this.

Thanks for your patience